[XPTI] Replace std::shared_mutex with SharedSpinLock#21502
Merged
againull merged 3 commits intointel:syclfrom Mar 18, 2026
Merged
[XPTI] Replace std::shared_mutex with SharedSpinLock#21502againull merged 3 commits intointel:syclfrom
std::shared_mutex with SharedSpinLock#21502againull merged 3 commits intointel:syclfrom
Conversation
Replace std::shared_mutex with xpti::SharedSpinLock for short critical sections for better performance.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces std::shared_mutex usage in the XPTI framework with xpti::SharedSpinLock (and xpti::SharedLock for reader locking) to reduce overhead for short critical sections.
Changes:
- Switch writer-side locking from
std::unique_lock<std::shared_mutex>tostd::lock_guard<xpti::SharedSpinLock>in tracepoint/payload and notification paths. - Switch reader-side locking from
std::shared_lock<std::shared_mutex>toxpti::SharedLockwhere applicable. - Update member declarations and comments to reflect the new lock type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| xptifw/src/xpti_trace_framework.cpp | Replaces shared-mutex locking in Tracepoints/Notifications with SharedSpinLock + SharedLock. |
| xptifw/include/xpti_string_table.hpp | Replaces StringTable shared-mutex locking with SharedSpinLock + SharedLock. |
Comments suppressed due to low confidence (1)
xptifw/include/xpti_string_table.hpp:15
- After replacing
std::shared_mutexwithxpti::SharedSpinLock, this header no longer uses anything from<shared_mutex>. Dropping that include will reduce unnecessary dependencies for includers of this header.
#include "parallel_hashmap/phmap.h"
#include "spin_lock.hpp"
#include "xpti/xpti_data_types.h"
#include <hash_table7.hpp>
#include <atomic>
#include <shared_mutex>
#include <unordered_map>
Contributor
Author
|
@cperkinsintel Could you please take a look. |
uditagarwal97
approved these changes
Mar 17, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
std::shared_mutexwithxpti::SharedSpinLockfor short critical sections for better performance.