[CI][Bench] Don't build and install "custom" UR in workflow#21517
Merged
Conversation
reuse already built SYCL instead. From time to time this was causing issues of mismatched SYCL and UR. We built UR on our own, as there's no UR's cmake files delivered in the "toolchain". We fixed that on Compute Benchmarks side so now just ur libs and headers are required.
lukaszstolarczuk
force-pushed
the
bench-rem-ur-option
branch
from
4a0b702 to
12adb31
Compare
Contributor
Author
|
dispatch job for this PR: https://github.com/intel/llvm/actions/runs/23453958157 |
lslusarczyk
approved these changes
Mar 24, 2026
Contributor
lslusarczyk
left a comment
lslusarczyk
left a comment
There was a problem hiding this comment.
Great cleanup! Love seeing so much code gone with no change in functionality.
Regarding the --ur option: if its only purpose is to compile or run tests, I believe we don't need it for benchmarks. If I understand correctly, we can safely remove it. I vote for getting rid of it.
PatKamin
approved these changes
Mar 24, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse already built SYCL instead. From time to time this was causing issues of mismatched SYCL and UR.
We've built UR on our own, as there's no UR's cmake files delivered in the "toolchain".
We fixed that on Compute Benchmarks side so now just ur libs and headers are required.