Skip to content

Revert "[libspirv] Fix ptx bindless image builtins to be Itanium-compliant"#21536

Closed
wenju-he wants to merge 1 commit intosyclfrom
revert-21466-libspirv-ImageArrayFetch-ImageArrayRead-SampledImageArrayFetch-mangling
Closed

Revert "[libspirv] Fix ptx bindless image builtins to be Itanium-compliant"#21536
wenju-he wants to merge 1 commit intosyclfrom
revert-21466-libspirv-ImageArrayFetch-ImageArrayRead-SampledImageArrayFetch-mangling

Conversation

@wenju-he
Copy link
Copy Markdown
Contributor

Reverts #21466

It caused new build fail:
Unable to demangle name: _Z23__spirv_ImageArrayFetchIDv2_cmFETCH_COORD_2_2_c

@wenju-he wenju-he requested review from a team and Maetveis as code owners March 17, 2026 07:49
@wenju-he wenju-he requested a review from rafNNN March 17, 2026 07:49
@wenju-he
Copy link
Copy Markdown
Contributor Author

wenju-he commented Mar 17, 2026

The build fail can also be fixed in #21537 without reverting #21466.

Copy link
Copy Markdown
Contributor

@Maetveis Maetveis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can land #21537, but if for some reason that takes longer than reasonable its okay for me to revert.

@wenju-he wenju-he closed this Mar 17, 2026
@wenju-he wenju-he deleted the revert-21466-libspirv-ImageArrayFetch-ImageArrayRead-SampledImageArrayFetch-mangling branch March 17, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants