Skip to content

[UR] Fix validation of arguments of urKernelLaunchWithArgsExp() #21628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 1 commit into from
Mar 26, 2026
+22 −18
Merged

[UR] Fix validation of arguments of urKernelLaunchWithArgsExp() #21628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions unified-runtime/include/unified-runtime/ur_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8735,11 +8735,12 @@ typedef struct ur_exp_kernel_arg_properties_t {
/// - ::UR_RESULT_ERROR_IN_EVENT_LIST_EXEC_STATUS
/// + An event in `phEventWaitList` has ::UR_EVENT_STATUS_ERROR.
/// - ::UR_RESULT_ERROR_INVALID_WORK_DIMENSION
/// + `pGlobalWorkSize[0] == 0 || pGlobalWorkSize[1] == 0 ||
/// pGlobalWorkSize[2] == 0`
/// + `pGlobalWorkSize[0] == 0 || (workDim >= 2 && pGlobalWorkSize[1] ==
/// 0) || (workDim >= 3 && pGlobalWorkSize[2] == 0)`
/// - ::UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE
/// + `pLocalWorkSize && (pLocalWorkSize[0] == 0 || pLocalWorkSize[1] ==
/// 0 || pLocalWorkSize[2] == 0)`
/// + `pLocalWorkSize && (pLocalWorkSize[0] == 0 || (workDim >= 2 &&
/// pLocalWorkSize[1] == 0) || (workDim >= 3 && pLocalWorkSize[2] ==
/// 0))`
/// - ::UR_RESULT_ERROR_INVALID_VALUE
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGS - "The kernel argument values
/// have not been specified."
Expand Down
4 changes: 2 additions & 2 deletions unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ returns:
- $X_RESULT_ERROR_IN_EVENT_LIST_EXEC_STATUS:
- "An event in `phEventWaitList` has $X_EVENT_STATUS_ERROR."
- $X_RESULT_ERROR_INVALID_WORK_DIMENSION:
- "`pGlobalWorkSize[0] == 0 || pGlobalWorkSize[1] == 0 || pGlobalWorkSize[2] == 0`"
- "`pGlobalWorkSize[0] == 0 || (workDim >= 2 && pGlobalWorkSize[1] == 0) || (workDim >= 3 && pGlobalWorkSize[2] == 0)`"
- $X_RESULT_ERROR_INVALID_WORK_GROUP_SIZE:
- "`pLocalWorkSize && (pLocalWorkSize[0] == 0 || pLocalWorkSize[1] == 0 || pLocalWorkSize[2] == 0)`"
- "`pLocalWorkSize && (pLocalWorkSize[0] == 0 || (workDim >= 2 && pLocalWorkSize[1] == 0) || (workDim >= 3 && pLocalWorkSize[2] == 0))`"
- $X_RESULT_ERROR_INVALID_VALUE
- $X_RESULT_ERROR_INVALID_KERNEL_ARGS
- "The kernel argument values have not been specified."
Expand Down
9 changes: 5 additions & 4 deletions unified-runtime/source/loader/layers/validation/ur_valddi.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions unified-runtime/source/loader/ur_libapi.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions unified-runtime/source/ur_api.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading