[SPIR-V] Don't lower builtin variadic functions (cherry pick)#21663
Merged
sarnex merged 2 commits intointel:syclfrom Apr 1, 2026
Merged
[SPIR-V] Don't lower builtin variadic functions (cherry pick)#21663sarnex merged 2 commits intointel:syclfrom
sarnex merged 2 commits intointel:syclfrom
Conversation
…ocl_printf" This reverts commit 9165e9c.
In llvm/llvm-project#178980 I tried to remove the special handling for `printf`, but the fix was wrong, the pass expects that `printf` abides by the variadic ABI (single buffer passed in, args extracted by caller), which isn't how it works. However the root issue is with any builtin, they are just replaced directly with instructions, and the only place that could generate code to honor the variadic ABI would bei in the SPIR-V backend, and it would be pretty complicated for pretty much no benefit. It's much simpler to teach the pass to skip certain functions, as we did before, but this time skip all SPIR-V builtin. --------- Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
YuriPlyakhin
approved these changes
Apr 1, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the workaround we did in pulldown here and cherry-pick the upstream fix here.
I will merge this into HEAD manually so we don't mess up the future pulldown, the PR title doesn't matter.
Postcommit run here.