[SYCL] Split sycl::half into an internal impl header#21832
Open
koparasy wants to merge 2 commits intointel:syclfrom
Open
[SYCL] Split sycl::half into an internal impl header#21832koparasy wants to merge 2 commits intointel:syclfrom
koparasy wants to merge 2 commits intointel:syclfrom
Conversation
koparasy
changed the title
Move the sycl::half implementation into detail/half_type_impl.hpp and keep sycl/half_type.hpp as the public wrapper for stream operators and std::hash. This lets internal headers, including builtins, depend on the half implementation without pulling in the full public half header that relies on std::optional and iostream. This reduces compile time by another 30ms on builtins.
koparasy
force-pushed
the
compile-time/split-half-type
branch
from
48ef4bb to
8f5fe4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #21821