[SYCL][NFC] Refactor IPC for memory#21934
Draft
slawekptak wants to merge 3 commits intointel:syclfrom
Draft
Conversation
cperkinsintel
approved these changes
May 7, 2026
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
So this all looks good, and I'm not familiar with the bigger plans for IPC. But it seems strange to me to be moving from one experimental namespace into a different experimental namespace with an ABI break and no changing of the functionality.
I understand this is preparation for incoming new work. But maybe we should just add the new namespace and leave the old one alone? Then we can deprecate the old one whenever we want and the new one doesn't have to be hidden behind the preview breaking changes flag, it can just be new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a common header to be used by all IPC features going forward (introduced by the sycl_ext_oneapi_inter_process_communication extension).
Change the memory IPC namespace name and use the new
handletype location introduced by #21949, in the SYCL Preview version. This will become the new IPC API design for all new IPC-related features going forward, and for IPC memory in the next ABI-breaking window.