[UR] Revert #21930#22065
Merged
Merged
Conversation
…signal (intel#21930)" This reverts commit e928aae.
0x12CC
approved these changes
May 19, 2026
winstonzhang-intel
approved these changes
May 19, 2026
enm-intel
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "[L0] Use immediate command lists for external semaphore wait/signal (#21930)"
This reverts commit e928aae.
By putting the semaphore on an immediate command list, but still using the original regular command list for the other graphic operations, we introduce some unsoundness that can lead to races and problems where the regular command list is the default. The better choice in the short term is to simply require that SYCL queues that are intended for semaphore usage use immediate command lists. I have a separate PR (in progress) that will make that change to the docs and tests and introduces a verification.
#22046