[libspirv] Use clc functions for __spirv_All/Any#22105
Merged
Merged
Conversation
They are now implemented with @llvm.vector.reduce.and/or, which can map
to native hardware instruction. Example llvm-diff changes (> is reference):
in function _Z11__spirv_AllDv2_c:
> %2 = extractelement <2 x i8> %0, i64 0
> %3 = extractelement <2 x i8> %0, i64 1
> %4 = and i8 %2, %3
< %2 = tail call i8 @llvm.vector.reduce.and.v2i8(<2 x i8> %0)
in function _Z11__spirv_AnyDv2_c:
> %2 = extractelement <2 x i8> %0, i64 0
> %3 = extractelement <2 x i8> %0, i64 1
> %4 = or i8 %2, %3
< %2 = tail call i8 @llvm.vector.reduce.or.v2i8(<2 x i8> %0)
Maetveis
approved these changes
May 25, 2026
Maetveis
left a comment
Maetveis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, great cleanup, thanks!
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are now implemented with @llvm.vector.reduce.and/or, which can map to native hardware instruction. Example llvm-diff changes (> is reference): in function _Z11__spirv_AllDv2_c:
> %2 = extractelement <2 x i8> %0, i64 0
> %3 = extractelement <2 x i8> %0, i64 1
> %4 = and i8 %2, %3
< %2 = tail call i8 @llvm.vector.reduce.and.v2i8(<2 x i8> %0)
in function _Z11__spirv_AnyDv2_c:
> %2 = extractelement <2 x i8> %0, i64 0
> %3 = extractelement <2 x i8> %0, i64 1
> %4 = or i8 %2, %3
< %2 = tail call i8 @llvm.vector.reduce.or.v2i8(<2 x i8> %0)