[SYCL][E2E] Fix test relating to interoperability between SYCL Bindless Images and DX11 texture#22137
Merged
dm-vodopyanov merged 7 commits intoMay 28, 2026
Conversation
0x12CC
approved these changes
May 28, 2026
| // XFAIL: run-mode | ||
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/15851 | ||
| // UNSUPPORTED: gpu-intel-gen12 | ||
| // UNSUPPORTED-INTENDED: Unknown issue with integrated GPU failing |
Contributor
There was a problem hiding this comment.
Can you create an issue for this? I don't think it needs to block the PR but we should track it.
…m/lbushi25/llvm into dx11_interop_bindless_images_test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the image descriptor used for the SYCL image in the
read_write_unsampled.cpptest to always be 2-dimensional in order to match the dimensionality of the texture used in DX11. The test was previously using images of dimensionality 1, 2 or 3 to access the memory of the 2D texture which may be undefined behavior. The iteration space, in other words the range of the kernel, continues to be 1, 2, or 3 dimensional but we do the conversion in the SYCL kernel itself to get a couple of coordinates (x,y) that we can use to index into the image from either a single number for a 1D iteration space, 2 numbers for a 2D iteration space or 3 numbers for a 3D iteration space. The conversion is:x -> (x, 0) for 1D iteration space
(x, y) -> (x, y) for 2D iteration space
(x, y, z) -> (x, dim1 * z + y) for a 3D iteration space with dimension sizes dim0, dim1 and dim2.
Closes: #20384
Closes: #21159