Skip to content

[SYCL][E2E] Fix test relating to interoperability between SYCL Bindless Images and DX11 texture#22137

Merged
dm-vodopyanov merged 7 commits into
intel:syclfrom
lbushi25:dx11_interop_bindless_images_test
May 28, 2026
Merged

[SYCL][E2E] Fix test relating to interoperability between SYCL Bindless Images and DX11 texture#22137
dm-vodopyanov merged 7 commits into
intel:syclfrom
lbushi25:dx11_interop_bindless_images_test

Conversation

@lbushi25
Copy link
Copy Markdown
Contributor

@lbushi25 lbushi25 commented May 27, 2026

Change the image descriptor used for the SYCL image in the read_write_unsampled.cpp test to always be 2-dimensional in order to match the dimensionality of the texture used in DX11. The test was previously using images of dimensionality 1, 2 or 3 to access the memory of the 2D texture which may be undefined behavior. The iteration space, in other words the range of the kernel, continues to be 1, 2, or 3 dimensional but we do the conversion in the SYCL kernel itself to get a couple of coordinates (x,y) that we can use to index into the image from either a single number for a 1D iteration space, 2 numbers for a 2D iteration space or 3 numbers for a 3D iteration space. The conversion is:

x -> (x, 0) for 1D iteration space
(x, y) -> (x, y) for 2D iteration space
(x, y, z) -> (x, dim1 * z + y) for a 3D iteration space with dimension sizes dim0, dim1 and dim2.

Closes: #20384
Closes: #21159

@lbushi25 lbushi25 marked this pull request as ready for review May 27, 2026 22:16
@lbushi25 lbushi25 requested a review from a team as a code owner May 27, 2026 22:16
// XFAIL: run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15851
// UNSUPPORTED: gpu-intel-gen12
// UNSUPPORTED-INTENDED: Unknown issue with integrated GPU failing
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue for this? I don't think it needs to block the PR but we should track it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done!

@dm-vodopyanov dm-vodopyanov merged commit 4340c56 into intel:sycl May 28, 2026
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DX11/DX12 interop test read_write_unsampled.cpp fails on Windows DG2 Bindless image interop failures with Win BMG driver 1.6.34938

3 participants