Revert "Enable cfg-printer LLVM lit tests only if LLVM linked statica… #3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly (intel#1479)" This reverts commit ff0b066. Closes intel#1478.
jsji
pushed a commit
that referenced
this pull request
Nov 4, 2025
The IRParser offers a higher level API, that allows us to also read bitcode assembly, and not only compiled bitcode. This allows us to skip the `llvm-as %s -o %t.bc` step in several tests. I've only updated 3 tests to show the difference; but we have more than 500 occurrences of `llvm-as %s -o` in the tests: > $ grep -r "llvm-as %s -o" | cut -d':' -f1 | sort -u | wc -l > 506 As a bonus, the function `llvm::getLazyIRFileModule` (https://llvm.org/doxygen/namespacellvm.html#aac226baa3ffd0f255a8d2b6d978b81b2) also calls `MemoryBuffer::getFileOrSTDIN`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@400be5144443c6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lly (#1479)"
This reverts commit ff0b066.
Closes #1478.