Closed
Conversation
added 30 commits
April 30, 2021 06:07
implement the 'act-on' functions.
'Expr' type, which required a ton of implementation... Whew, at least that is over. A couple of 'TODO's remain, but we'll get to those eventually.
… the name/mark the name, and some other various TODOs there
…e in both SEMA and CodeGen without duplication
… we jsut use the tree-trnasform behavior
…XXNameMangler handles the string..
…he callback type is reasonably right
…mbda' registration is a little wrong right now though
I was trying to use the same lambda to do 2 different things, determine whether the lambda needed this mangling, and doing the mangling. Unfortuantely the logic/split there was not particularly useful. Changed back to have these function-pointers always be populated and switched to 2 different calls. This allows us to not have a conflict on not-participate-in-kernel with lambda ID #0 and ID#1 (0 is supposed to be mangled as an unnamed struct, and #1 is mangled with id 0).
This just makes it not particularly usable in the clang-c interface, which I believe we're OK with. In the future, we can re-add this behavior if we care to.
…ters are a thing too
The load was doing some funny stuff trying to turn the type of our builtin into an i8 instead of an i8*. However, it seems that when we use a global we typically just want to wrap it in a GEP to get the 1st element. This is auto-generated for us if we jsut return the string itself.
…rrect AS, then addr-space-cast if necessary
added 6 commits
April 30, 2021 15:39
Contributor
|
/summary:run |
Contributor
|
/summary:all |
iclsrc
pushed a commit
that referenced
this pull request
Apr 10, 2026
A recent version of SPIRV-Tools found several issues with the test, such as `DebugTypeFunction` having the wrong return type operand and `DebugTypeBasic` missing the flags operand. Original commit: KhronosGroup/SPIRV-LLVM-Translator@bf469923a25d484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just in place for validating.
@schittir and @AaronBallman , jsut FYI, no reason to review.