Skip to content

Fix warning on build with clang based compiler#3680

Merged
pvchupin merged 1 commit intointel:syclfrom
pvchupin:fix-warnings
May 3, 2021
Merged

Fix warning on build with clang based compiler#3680
pvchupin merged 1 commit intointel:syclfrom
pvchupin:fix-warnings

Conversation

@pvchupin
Copy link
Copy Markdown
Contributor

@pvchupin pvchupin commented May 3, 2021

.../llvm/clang/lib/Sema/SemaSYCL.cpp(4662,10):
error: moving a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
return std::move(NewShimName);
^
.../llvm/clang/lib/Sema/SemaSYCL.cpp(4662,10):
note: remove std::move call here
return std::move(NewShimName);
^~~~~~~~~~ ~

Signed-off-by: Pavel V Chupin pavel.v.chupin@intel.com

.../llvm/clang/lib/Sema/SemaSYCL.cpp(4662,10):
error: moving a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(NewShimName);
         ^
.../llvm/clang/lib/Sema/SemaSYCL.cpp(4662,10):
note: remove std::move call here
  return std::move(NewShimName);
         ^~~~~~~~~~           ~

Signed-off-by: Pavel V Chupin <pavel.v.chupin@intel.com>
Copy link
Copy Markdown
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvchupin pvchupin merged commit 7f6da43 into intel:sycl May 3, 2021
@pvchupin pvchupin deleted the fix-warnings branch August 24, 2021 22:58
iclsrc pushed a commit that referenced this pull request Apr 30, 2026
)

Some spirv-val invocations are failing with newer SPIRV-Tools
(`e4bceacf`) for PtrCastToGeneric OpSpecConstantOps with the error:

    Expected input and Result Type to point to the same type

Disable the spirv-val steps temporarily.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@7de094bda017e2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants