[ESIMD] Overloading sycl sin,cos,exp,log functions for ESIMD arguments#3717
Conversation
|
The test is here: intel/llvm-test-suite#312 |
DenisBakhvalov
force-pushed
the
sycl_esimd-vectorize5
branch
2 times, most recently
from
5767974 to
b7c2dc9
Compare
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
Looks like I did not hit "submit" the first time :(
There was a problem hiding this comment.
I think for device it should be noexcept, as for all device functions, for host - same as usual SYCL host.
There was a problem hiding this comment.
I copied it from builtins.hpp.
There was a problem hiding this comment.
not clear why this specialization is needed?
There was a problem hiding this comment.
I couldn't remember why I added it. But it looks like now it's not needed. I deleted it.
There was a problem hiding this comment.
this one is already defined:
sycl/include/sycl/ext/intel/experimental/esimd/common.hpp:#define __ESIMD_NS sycl::ext::intel::experimental::esimd
DenisBakhvalov
force-pushed
the
sycl_esimd-vectorize5
branch
from
b7c2dc9 to
003eea7
Compare
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
please add E2E tests also
|
@DenisBakhvalov, I suggest to change the title for more clarity - this is really overloading sycl:: functions for ESIMD arguments. |
|
@bader - please review. This overloading approach was agreed upon with @rolandschulz and @Pennycook. |
E2E tests are here: intel/llvm-test-suite#312 |
DenisBakhvalov
changed the title
|
@bader, @alexbatashev, @v-klochkov or other folks from rt reviewers - please approve |
* upstream/sycl: (776 commits) Align CMake requirements with upstream. (intel#3928) [SYCL] Deprecate [[intel::reqd_work_group_size]] attribute spelling (intel#3927) [SYCL] Fix post commit after PR 2292 (intel#3939) {SYCL][PI][L0] - Eliminate std::string construction/destruction overhead. (intel#3931) [ESIMD] Overloading sycl sin,cos,exp,log functions for ESIMD arguments (intel#3717) [sycl-post-link] Add device image property for assert feature (intel#3881) [SYCL] Split read/write lockings (intel#2292) Handle OpSpecConstantOp with Select Handle OpSpecConstantOp with SMod Add tests for SConvert, UConvert, BitCast OpSpecConstantOp Fix attachment of decoration to spec constants Implement support for dynamic memmove Align clang-tidy/format versions to LLVM version Handle OpSpecConstantOp for integer comparisons Handle OpSpecConstantOp for SNegate, Not, and LogicalNot Extend OpSpecConstantOp testing for initializers Use IRBuilder for folding Fix translating of compile unit Support buffers in LinalgFoldUnitExtentDims [gn build] Port d0a5d86 ...
…sts (#3717) Enable tests that pass on the latest LLVM revision Original commit: KhronosGroup/SPIRV-LLVM-Translator@8f759502ce0d6fa
4 participants
No description provided.