[SYCL] Fix spec constants when device split is enabled#3747
Closed
alexbatashev wants to merge 1 commit into
Closed
[SYCL] Fix spec constants when device split is enabled#3747alexbatashev wants to merge 1 commit into
alexbatashev wants to merge 1 commit into
Conversation
SYCL tooling performs specialization constants extraction before code split. As a result, device image may contain properties, that describe spec constants not present in device image. Do not advertise default values as set to avoid incorrect API calls.
jsji
pushed a commit
that referenced
this pull request
May 14, 2026
NonSemantic.Shader.DebugInfo.100/.200 require the Source operand of DebugLine to reference a DebugSource instruction, not a raw OpString ID (DIFile in LLVM IR). Use getSource() to emit a proper DebugSource reference. Enable spirv-val on the NonSemantic paths of DebugInfoTypeBasic.ll and InlineNamespace.ll now that all previous spec-compliance fixes are in place. AI-assisted: Claude Sonnet 4.6 (commercial SaaS) Original commit: KhronosGroup/SPIRV-LLVM-Translator@38a315ed3cc0d91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYCL tooling performs specialization constants extraction before code
split. As a result, device image may contain properties, that describe
spec constants not present in device image. Do not advertise default
values as set to avoid incorrect API calls.