Skip to content

Handle translation of llvm.invariant.* intrinsics #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Handle translation of llvm.invariant.* intrinsics #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions llvm-spirv/lib/SPIRV/SPIRVWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,9 +1399,13 @@ SPIRVValue *LLVMToSPIRV::transIntrinsicInst(IntrinsicInst *II,
}
return 0;
}
// We can just ignore/drop some intrinsics, like optimizations hint.
case Intrinsic::invariant_start:
case Intrinsic::invariant_end:
return nullptr;
default:
// LLVM intrinsic functions shouldn't get to SPIRV, because they
// would have no definition there.
// Other LLVM intrinsics shouldn't get to SPIRV, because they
// can't be represented in SPIRV or not implemented yet.
BM->getErrorLog().checkError(false, SPIRVEC_InvalidFunctionCall,
II->getCalledValue()->getName().str(), "",
__FILE__, __LINE__);
Expand Down
32 changes: 32 additions & 0 deletions llvm-spirv/test/llvm.invariant.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
; Make sure the translator doesn't crash if the input LLVM IR contains llvm.invariant.* intrinsics
; RUN: llvm-as < %s -o %t.bc
; RUN: llvm-spirv %t.bc -o %t.spv
; RUN: spirv-val %t.spv
; RUN: llvm-spirv -to-text %t.spv -o - | FileCheck %s

; CHECK-NOT: FunctionParameter
; CHECK-NOT: FunctionCall

source_filename = "<stdin>"
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024"
target triple = "spir64-unknown-linux-sycldevice"

@WGSharedVar = internal addrspace(3) constant i64 0, align 8

; Function Attrs: argmemonly nounwind
declare {}* @llvm.invariant.start.p3i8(i64 immarg, i8 addrspace(3)* nocapture) #0

; Function Attrs: argmemonly nounwind
declare void @llvm.invariant.end.p3i8({}*, i64 immarg, i8 addrspace(3)* nocapture) #0

define linkonce_odr dso_local spir_func void @func() {
store i64 2, i64 addrspace(3)* @WGSharedVar
%1 = bitcast i64 addrspace(3)* @WGSharedVar to i8 addrspace(3)*
%2 = call {}* @llvm.invariant.start.p3i8(i64 8, i8 addrspace(3)* %1)
call void @llvm.invariant.end.p3i8({}* %2, i64 8, i8 addrspace(3)* %1)
ret void
}

attributes #0 = { argmemonly nounwind }

!spirv.ExecutionMode = !{}