Skip to content

[SYCL][NFC] Fix skipping KernelBundleWith2Kernels test #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021
Merged

[SYCL][NFC] Fix skipping KernelBundleWith2Kernels test #5225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/unittests/helpers/PiMock.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ namespace RT = detail::pi;
/// redefinitions would also affect other platforms' behavior.
/// Therefore, any plugin-related information is fully copied whenever
/// a user-passed SYCL object instance is being mocked.
/// The underlying SYCL platform must be a non-host plaftorm to facilitate
/// The underlying SYCL platform must be a non-host platform to facilitate
/// plugin usage.
///
/// Simple usage examples would look like this:
Expand Down
14 changes: 5 additions & 9 deletions sycl/unittests/program_manager/EliminatedArgMask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,11 @@ sycl::detail::ProgramManager::KernelArgMask getKernelArgMaskFromBundle(
// kernel bundle after two kernels are compiled and linked.
TEST(EliminatedArgMask, KernelBundleWith2Kernels) {
sycl::platform Plt{sycl::default_selector()};
if (Plt.is_host()) {
std::cerr << "Test is not supported on host, skipping\n";
return; // test is not supported on host.
} else if (Plt.get_backend() == sycl::backend::ext_oneapi_cuda) {
std::cerr << "Test is not supported on CUDA platform, skipping\n";
return;
} else if (Plt.get_backend() == sycl::backend::ext_oneapi_hip) {
std::cout << "Test is not supported on HIP platform, skipping\n";
return;
if (Plt.is_host() || Plt.get_backend() == sycl::backend::ext_oneapi_cuda ||
Plt.get_backend() == sycl::backend::ext_oneapi_hip) {
std::cerr << "Test is not supported on "
<< Plt.get_info<sycl::info::platform::name>() << ", skipping\n";
GTEST_SKIP(); // test is not supported on selected platform.
}

sycl::unittest::PiMock Mock{Plt};
Expand Down