[SYCL][NFC] Relax LIT test checks to avoid false alarms#553
Merged
bader merged 1 commit intointel:syclfrom Aug 27, 2019
Merged
Conversation
False failures might happen when LLVM function/type attributes are assigned differently. There is no value in checking LLVM intrinsic functions declarations. Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Fznamznon
approved these changes
Aug 27, 2019
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Jun 1, 2020
* Refined condition for CapabilityVector16 * Removed redundant assert from SPIRVVectorShuffle This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes. * Added required capabilities for ExecutionModeSubgroupSize * Added missing float control capabilities to SPIRVIsValidEnum.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
False failures might happen when LLVM function/type attributes are assigned differently.
There is no value in checking LLVM intrinsic functions declarations.