[SYCL] Move simple event_impl constructor to header #6611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain systems unittests that uses the event_impl constructor with no arguments may disagree with the event_impl source file on the layout of the default std::optional argument. This can cause unexpected memory accesses when performing operations on the passed argument. This commit works around this issue by moving the body of the constructor to the header. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
cperkinsintel
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain systems unittests that uses the event_impl constructor with no arguments may disagree with the event_impl source file on the layout of the default std::optional argument. This can cause unexpected memory accesses when performing operations on the passed argument. This commit works around this issue by moving the body of the constructor to the header.