Skip to content

[SYCL] Move simple event_impl constructor to header #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[SYCL] Move simple event_impl constructor to header #6611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sycl/source/detail/event_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ void event_impl::setContextImpl(const ContextImplPtr &Context) {
MIsContextInitialized = true;
}

event_impl::event_impl(std::optional<HostEventState> State)
: MIsInitialized(false), MHostEvent(State), MIsFlushed(true),
MState(State.value_or(HES_Complete)) {}

event_impl::event_impl(RT::PiEvent Event, const context &SyclContext)
: MIsContextInitialized(true), MEvent(Event),
MContext(detail::getSyclObjImpl(SyclContext)), MHostEvent(false),
Expand Down
4 changes: 3 additions & 1 deletion sycl/source/detail/event_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ class event_impl {
/// If the constructed SYCL event is waited on it will complete immediately.
/// Normally constructs a host event, use std::nullopt to instead instantiate
/// a device event.
event_impl(std::optional<HostEventState> State = HES_Complete);
event_impl(std::optional<HostEventState> State = HES_Complete)
: MIsInitialized(false), MHostEvent(State), MIsFlushed(true),
MState(State.value_or(HES_Complete)) {}

/// Constructs an event instance from a plug-in event handle.
///
Expand Down