Skip to content

[SYCL] Rewrite some LIT tests into unit-tests #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SYCL] Rewrite some LIT tests into unit-tests #8180

wants to merge 2 commits into from

Conversation

@AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Feb 2, 2023

No description provided.

@AlexeySachkov AlexeySachkov temporarily deployed to aws February 2, 2023 11:52 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024

This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

This pull request was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this Oct 16, 2024
@uditagarwal97
Copy link
Contributor

uditagarwal97 commented Oct 21, 2024

@AlexeySachkov Should we re-open this PR? The change still looks relevant to me, in the scope of CMPLRLLVM-32351

@AlexeySachkov
Copy link
Contributor Author

AlexeySachkov commented Oct 21, 2024

@AlexeySachkov Should we re-open this PR? The change still looks relevant to me, in the scope of CMPLRLLVM-32351

@uditagarwal97, I have no objections, but that is not on the top of my queue currently. Feel free to take the diff into your own PR, or just update this one to refresh it and restart CI and review.

I honestly don't remember why I never finished it - I suppose I wanted to include some more tests into it? But that shouldn't be a blocker either

@uditagarwal97 uditagarwal97 mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexeySachkov @uditagarwal97