[SYCL] Fix refcounting for kernel_bundle interop with OpenCL #8465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenCL interop spec basically says that each "conversion" must adjust reference counter of the underlying object. Many of the interop interfaces had been fixed in intel#3236 but the majority of the kernel_bundle feature was implemented after that and made the same omission. I'm not sure if that is the best way to fix it though. Another alternative would be to move all these retains into the OpenCL PI plugin.
Contributor
Author
Contributor
Author
|
/verify with intel/llvm-test-suite#1622 |
smaslov-intel
approved these changes
Mar 2, 2023
Contributor
Author
|
@intel/llvm-gatekeepers both this PR and its llvm-test-suite counterpart are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCL interop spec basically says that each "conversion" must adjust reference counter of the underlying object. Many of the interop interfaces had been fixed in #3236 but the majority of the kernel_bundle feature was implemented after that and made the same omission.
I'm not sure if that is the best way to fix it though. Another alternative would be to move all these retains into the OpenCL PI plugin.