[SYCL] Fix integration footer for specialization_id #8959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type printer for specialization_id in SemaSYCL did not
correctly handle class template specializations. The
template parameters were omitted in generated shim
functions i.e. for the following code,
namespace {
namespace inner {
template <int Val>
struct S3 {
static constexpr sycl::specialization_id a{Val};
};
}
}
inner::S3::a was generated in shim functions instead of
inner::S3<10>::a. This patch fixes this error
smanna12
approved these changes
Apr 5, 2023
Fznamznon
approved these changes
Apr 6, 2023
Contributor
Author
|
@intel/llvm-gatekeepers PR is ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type printer for specialization_id in SemaSYCL did not
correctly handle class template specializations. The
template parameters were omitted in generated shim
functions i.e. for the following code,
namespace {
namespace inner {
template
struct S3 {
static constexpr sycl::specialization_id a{Val};
};
}
}
template class inner::S3<10>;
inner::S3::a was generated in shim functions instead of
inner::S3<10>::a. This patch fixes this error