Revert "[SYCL][NFC] Remove SYCL specific TargetInfo types" #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
force-pushed
the
revert-965-exception-workaround
branch
from
bb77278 to
8ee7c3e
Compare
This reverts commit ab8e5fe. This patch effectively breaks Ubuntu 16 or any other system which has GCC < 7.1. Before GCC 7.1, `exception_ptr` was only available if `ATOMIC_INT_LOCK_FREE > 1` (see [this commit](gcc-mirror/gcc@c45be7f)), which doesn't seem to be true for `SPIR*TargetInfo`. Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
AlexeySachkov
force-pushed
the
revert-965-exception-workaround
branch
from
8ee7c3e to
1335ad3
Compare
romanovvlad
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #965
This patch effectively breaks Ubuntu 16 or any other system which has GCC < 7.1.
Before GCC 7.1,
exception_ptrwas only available ifATOMIC_INT_LOCK_FREE > 1(see this commit), which doesn't seem to be true forSPIR*TargetInfo.