[SYCL][NFC] Remove SYCL specific TargetInfo types #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround is not needed anymore. Signed-off-by: Alexey Bader <alexey.bader@intel.com>
bader
changed the title
bader
force-pushed
the
exception-workaround
branch
from
4564fc5 to
6fd151b
Compare
erichkeane
approved these changes
Dec 23, 2019
Contributor
erichkeane
left a comment
erichkeane
left a comment
There was a problem hiding this comment.
LGTM. Wouldn't mind if @mibintc took a look.
Fznamznon
approved these changes
Dec 24, 2019
mibintc
reviewed
Dec 24, 2019
| return new MicrosoftX86_32SPIRTargetInfo(Triple, Opts); | ||
| } | ||
| case llvm::Triple::Linux: | ||
| return new LinuxTargetInfo<SPIR32SYCLDeviceTargetInfo>(Triple, Opts); |
There was a problem hiding this comment.
You don't need LinuxTargetInfo any more for SPIR device?
Contributor
Author
There was a problem hiding this comment.
No. There is no Linux on SPIR devices.
Contributor
|
This effectively breaks Ubuntu 16 or any other system which has GCC < 7.1. Before GCC 7.1, |
AlexeySachkov
added a commit
that referenced
this pull request
Dec 26, 2019
This reverts commit ab8e5fe. This patch effectively breaks Ubuntu 16 or any other system which has GCC < 7.1. Before GCC 7.1, `exception_ptr` was only available if `ATOMIC_INT_LOCK_FREE > 1` (see [this commit](gcc-mirror/gcc@c45be7f)), which doesn't seem to be true for `SPIR*TargetInfo`. Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
romanovvlad
pushed a commit
that referenced
this pull request
Dec 26, 2019
This reverts commit ab8e5fe. This patch effectively breaks Ubuntu 16 or any other system which has GCC < 7.1. Before GCC 7.1, `exception_ptr` was only available if `ATOMIC_INT_LOCK_FREE > 1` (see [this commit](gcc-mirror/gcc@c45be7f)), which doesn't seem to be true for `SPIR*TargetInfo`. Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
coldav
pushed a commit
to coldav/llvm
that referenced
this pull request
Sep 2, 2025
Remove outdated test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround is not needed anymore.
Signed-off-by: Alexey Bader alexey.bader@intel.com