[SYCL][UR][L0] Do not destroy build log on piProgramBuild #9980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If piProgramBuild fails, do not remove L0 build log, which is expected to be read later in piProgramGetBuildInfo. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Contributor
Author
|
changes are specific to L0, and the failure is on CUDA suite, so unrelated. |
Contributor
|
@jandres742 : this was already fixed in #8848 |
Contributor
Author
@smaslov-intel : yes, it is destroyed later in urProgramGetBuildInfo after printing the string, and also on program destructor. This seems to have been an error introduced during the porting to UR, which was done after the #8848 PR you mentioned. |
againull
approved these changes
Jun 20, 2023
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
If piProgramBuild fails, do not remove L0 build log, which is expected to be read later in piProgramGetBuildInfo. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If piProgramBuild fails, do not remove L0 build log, which is expected to be read later in piProgramGetBuildInfo.