[Media Common]Fix the user setting memory free#1305
Merged
intel-mediadev merged 1 commit intointel:masterfrom Dec 9, 2021
Merged
[Media Common]Fix the user setting memory free#1305intel-mediadev merged 1 commit intointel:masterfrom
intel-mediadev merged 1 commit intointel:masterfrom
Conversation
XinfengZhang
approved these changes
Dec 3, 2021
XinfengZhang
reviewed
Dec 3, 2021
| MOS_AtomicIncrement(&MosUtilities::m_mosMemAllocFakeCounter); //ulValueBuf does not count it, because it is freed after the MEMNJA final report. | ||
| MOS_OS_NORMALMESSAGE("ulValueBuf %p for key %s", ulValueBuf, NewKey.pValueArray[0].pcValueName); | ||
|
|
||
| m_userSettingMutex.Lock(); |
Contributor
There was a problem hiding this comment.
how about multiple-process case?
Contributor
Author
|
Hi,
Different process loads different .so. The mutex is different. This function only writes value to cpu memory not write to files.
Best Wishes,
Pingli
From: XinfengZhang ***@***.***>
Sent: Friday, December 3, 2021 3:57 PM
To: intel/media-driver ***@***.***>
Cc: Wang, Pingli ***@***.***>; Author ***@***.***>
Subject: Re: [intel/media-driver] [Media Common]Fix the user setting memory free (PR #1305)
@XinfengZhang commented on this pull request.
________________________________
In media_softlet/linux/common/os/mos_utilities_specific_next.cpp<#1305 (comment)>:
@@ -612,6 +613,7 @@ MOS_STATUS MosUtilitiesSpecificNext::UserFeatureSet(MOS_PUF_KEYLIST *pKeyList, M
MOS_AtomicIncrement(&MosUtilities::m_mosMemAllocFakeCounter); //ulValueBuf does not count it, because it is freed after the MEMNJA final report.
MOS_OS_NORMALMESSAGE("ulValueBuf %p for key %s", ulValueBuf, NewKey.pValueArray[0].pcValueName);
+ m_userSettingMutex.Lock();
how about multiple-process case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1305 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKFA6ONDJQ7VPZWFNMUQKCTUPBZ55ANCNFSM5JGV3VMQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
|
@pingliwa could you please rebase this PR? |
This commit fix the intel#1300 Signed-off-by: Wang, Pingli <pingli.wang@intel.com>
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix the #1300
Signed-off-by: Wang, Pingli pingli.wang@intel.com