Skip to content

Conversation

@KTokarze
Copy link
Contributor

This pull request updates the device ID assignments for several network device families in mfd_const/network.py. The main change is the reallocation of the device IDs 0x579C, 0x579D, 0x579E, and 0x579F from the CPK_SMBM family to the GNRD family and the sceb group, ensuring that device ID mappings are accurate and consistent.

Device ID reallocation:

  • Removed device IDs 0x579C, 0x579D, 0x579E, and 0x579F from the CPK_SMBM family assignment lists and tuples. [1] [2] [3]
  • Added device IDs 0x579C, 0x579D, 0x579E, and 0x579F to the GNRD family assignment lists and tuples. [1] [2]
  • Updated the sceb group to include device IDs 0x579E and 0x579F, in addition to the existing 0x579C and 0x579D.

Signed-off-by: Kacper Tokarzewski <kacper.tokarzewski@intel.com>
Copilot AI review requested due to automatic review settings November 17, 2025 07:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the device family classification for GNR-D network devices by moving device IDs 0x579C, 0x579D, 0x579E, and 0x579F from the CPK family to the GNRD family where they belong.

Key Changes:

  • Relocated four device IDs (0x579C, 0x579D, 0x579E, 0x579F) from CPK_SMBM family to GNRD family
  • Updated the sceb group to include all four device IDs (previously only contained 0x579C and 0x579D)
  • Ensured consistency across both string-based and DeviceID-based data structures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mchromin mchromin merged commit c30d93e into intel:main Nov 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants