fix: Add optional additional parameters for bridge creation #32
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for optional additional parameters when creating network bridges in the Linux IP feature implementation. The change allows users to pass extra configuration options to the underlying ip link add command for more flexible bridge creation.
Key Changes:
- Added
additional_parametersparameter to thecreate_bridgemethod with a default empty string value - Updated the command construction to include the additional parameters in the bridge creation command
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes intel#31 Signed-off-by: Rafał Głombiowski rafalx.glombiowski@intel.com
rafalglx
force-pushed
the
fix__Add_optional_additional_parameters_for_bridge_creation
branch
from
cd5ed6d to
9bd461d
Compare
adrianlasota
requested changes
Oct 24, 2025
|
|
||
| def create_bridge(self, bridge_name: str, namespace: Optional[str] = None) -> None: | ||
| def create_bridge( | ||
| self, bridge_name: str, additional_parameters: Optional[str] = None, namespace: Optional[str] = None |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31