Skip to content

fix: Add optional additional parameters for bridge creation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix: Add optional additional parameters for bridge creation #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions mfd_network_adapter/network_adapter_owner/feature/ip/linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,22 @@
class LinuxIP(BaseIPFeature):
"""Linux class for IP feature."""

def create_bridge(self, bridge_name: str, namespace: Optional[str] = None) -> None:
def create_bridge(
self, bridge_name: str, additional_parameters: Optional[str] = None, namespace: Optional[str] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use new typrhints https://web.yammer.com/main/threads/eyJfdHlwZSI6IlRocmVhZCIsImlkIjoiMjYzNDcxMDU2MjU2MjA0OCJ9

) -> None:
"""
Create bridge.
:param bridge_name: Bridge name.
:param additional_parameters: Additional parameters for bridge creation.
:param namespace: Name of network namespace
"""
self._connection.execute_command(
add_namespace_call_command(f"ip link add name {bridge_name} type bridge", namespace=namespace)
add_namespace_call_command(
f"ip link add name {bridge_name} type bridge"
f"{' ' + additional_parameters if additional_parameters else ''}",
namespace=namespace,
)
)

def delete_bridge(self, bridge_name: str, namespace: Optional[str] = None) -> None:
Expand Down
11 changes: 11 additions & 0 deletions ...test_mfd_network_adapter/test_network_adapter_owner/test_feature/test_ip/test_ip_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ def test_create_bridge(self, owner):
owner.ip.create_bridge(bridge_name)
owner._connection.execute_command.assert_called_once_with(f"ip link add name {bridge_name} type bridge")

def test_create_bridge_with_additional_parameters(self, owner):
owner._connection.execute_command.return_value = ConnectionCompletedProcess(
return_code=0, args="", stdout="", stderr=""
)
bridge_name = "br1"
additional_parameters = "ageing_time 0"
owner.ip.create_bridge(bridge_name, additional_parameters)
owner._connection.execute_command.assert_called_once_with(
f"ip link add name {bridge_name} type bridge ageing_time 0"
)

def test_delete_bridge(self, owner):
owner._connection.execute_command.return_value = ConnectionCompletedProcess(
return_code=0, args="", stdout="", stderr=""
Expand Down