feat: Add InterfaceType.VPORT to supported interface types for Virtualization feature#49
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands Linux virtualization feature support to accept InterfaceType.VPORT in addition to the existing PF and BTS interface types, and updates related documentation/tests accordingly.
Changes:
- Allow
InterfaceType.VPORTinLinuxVirtualization._raise_error_if_not_supported_type(). - Update multiple docstrings to reflect the expanded set of supported interface types.
- Add a unit test asserting that
VPORTpasses the supported-type check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mfd_network_adapter/network_interface/feature/virtualization/linux.py |
Extends supported interface type validation to include VPORT and updates docstrings. |
tests/unit/test_mfd_network_adapter/test_network_interface/test_feature/test_virtualization/test_virtualization_linux.py |
Adds coverage to ensure VPORT is accepted by the supported-type guard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KTokarze
force-pushed
the
add_vport_to_supported_types
branch
from
2db5a9d to
f581306
Compare
…lization feature Signed-off-by: Kacper Tokarzewski <kacper.tokarzewski@intel.com>
KTokarze
force-pushed
the
add_vport_to_supported_types
branch
from
f581306 to
54cde66
Compare
mchromin
approved these changes
May 19, 2026
adrianlasota
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the supported interface types for virtualization features in
linux.pyto includeVPORT, in addition to the existingPFandBTStypes. It updates both the implementation and all related docstrings to reflect this change, and adds a new unit test to verify the new behavior.Support for VPORT interface type:
_raise_error_if_not_supported_typeto allowVPORTas a supported interface type, alongsidePFandBTS(linux.py).linux.pyto indicate thatVirtualizationWrongInterfaceExceptionis now raised for non-PF/BTS/VPORTinterfaces, instead of just non-PFinterfaces. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Testing:
test__raise_error_if_not_pf_passes_vportto ensure thatVPORTis accepted as a valid interface type for virtualization features (test_virtualization_linux.py).