[Transform][RemoveSingleElemVector] Add support for vector.store lowering pattern for single-elem vector.#1011
Merged
mshahneo merged 1 commit intointel:mainfrom Jan 28, 2025
Conversation
mshahneo
changed the title
Garra1980
approved these changes
Jan 28, 2025
…ring pattern for single-elem vector. SPIR-V does not support single element vector, hence vector.store with single element vector needs to be transformed in way suitable for SPIR-V conversion. Since, the single element vector needs to be converted to a scalar and vector.store does not support scalar, replacing vector.store with memref.store.
mshahneo
force-pushed
the
FSW-12505_for_upstream
branch
from
eae6f1e to
e159885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIR-V does not support single element vector, hence vector.store with single element vector needs to be transformed in way suitable for SPIR-V conversion.
Since, the single element vector needs to be converted to a scalar and vector.store does not support scalar, replacing vector.store with memref.store.
Please review these guidelines to help with the review process: