[JAX] Fix reversible embedding#2496
Merged
Merged
Conversation
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses JAX/Keras quantization gaps for ReversibleEmbedding by ensuring the layer is correctly discovered/registered for quantization across Keras/KerasHub namespaces, and adjusts the quantized reversible embedding implementation to align with the updated base-class references (including load/call path behavior).
Changes:
- Register
ReversibleEmbeddingquantized wrappers for bothkeras.layers.*andkeras_hub.layers.*entry points (static and dynamic). - Standardize layer references to
keras.layers.*/keras_hub.layers.*module-qualified names instead of direct imports. - Update
super(...)calls in quantized reversible embedding to match the new base-class qualification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| neural_compressor/jax/quantization/layers_static.py | Adds dual registration for static ReversibleEmbedding and updates base-class references / call path. |
| neural_compressor/jax/quantization/layers_dynamic.py | Adds dual registration for dynamic ReversibleEmbedding and updates base-class references / call path. |
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing registrations for ReversibleEmbedding, which caused this layer not to be quantized.
This also revealed an issue with weights loading for QStaticReversibleEmbedding, which this PR also fixes.