Conversation
Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
…nto lvl/ILITV-2583 Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
…nto lvl/ILITV-2583 Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
chensuyue
approved these changes
Dec 30, 2022
VincyZhang
pushed a commit
that referenced
this pull request
Feb 12, 2023
yiliu30
pushed a commit
that referenced
this pull request
Mar 12, 2026
* Fix all 96 Coverity CIDs across 40 files CWE-476: Null pointer dereference fixes (null checks, variable initialization) CWE-328: Weak hash algorithm (sha1 -> sha256) CWE-561: Dead code removal (unreachable code, dead assignments) CWE-398: Code quality (bare except, unused imports, resource handling) CWE-532: Information exposure through log files (sanitize logging) CWE-688: Function call with incorrect variable (fix parameter shadowing) * Coverity-related fixes in 27 existing files (no new files). * Replace coverity asserts with logger.error and revert behavior changes - Replace 4 added asserts with logger.error in coco.py, test_pt2e_quant.py, test_pruning.py - Revert use_cuda, recipe_cfgs default, strategy deepcopy, textual_inversion flow, teacher_model guard, pt2e utility var, static_quant timing, self_distillation log, inc_dataset_loader error handling, pruneOFA/glueOFA renames, distillation prints - Keep all legitimate Coverity fixes (null checks, hash upgrades, resource leaks, etc.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore min_max variable removed incorrectly by coverity fix The variable is used on lines 147 and 154 - removing it breaks quantization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert fuse_qdq_conv to use new_match_node_name with init protection Initialize new_match_node_name = match_node_name before the if block so the original new_match_node_name[-1] usage is preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore config = AutoConfig.from_pretrained() in gpt-j/main.py Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Replace print with logger.error for stats None check Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix missing else branch in textual_inversion.py verify_loading Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add None guard for recipe_cfgs before .get() call Keeps default as None (original behavior) but prevents AttributeError. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xin3he
pushed a commit
that referenced
this pull request
Mar 31, 2026
* Fix all 96 Coverity CIDs across 40 files CWE-476: Null pointer dereference fixes (null checks, variable initialization) CWE-328: Weak hash algorithm (sha1 -> sha256) CWE-561: Dead code removal (unreachable code, dead assignments) CWE-398: Code quality (bare except, unused imports, resource handling) CWE-532: Information exposure through log files (sanitize logging) CWE-688: Function call with incorrect variable (fix parameter shadowing) * Coverity-related fixes in 27 existing files (no new files). * Replace coverity asserts with logger.error and revert behavior changes - Replace 4 added asserts with logger.error in coco.py, test_pt2e_quant.py, test_pruning.py - Revert use_cuda, recipe_cfgs default, strategy deepcopy, textual_inversion flow, teacher_model guard, pt2e utility var, static_quant timing, self_distillation log, inc_dataset_loader error handling, pruneOFA/glueOFA renames, distillation prints - Keep all legitimate Coverity fixes (null checks, hash upgrades, resource leaks, etc.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore min_max variable removed incorrectly by coverity fix The variable is used on lines 147 and 154 - removing it breaks quantization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert fuse_qdq_conv to use new_match_node_name with init protection Initialize new_match_node_name = match_node_name before the if block so the original new_match_node_name[-1] usage is preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore config = AutoConfig.from_pretrained() in gpt-j/main.py Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Replace print with logger.error for stats None check Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix missing else branch in textual_inversion.py verify_loading Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add None guard for recipe_cfgs before .get() call Keeps default as None (original behavior) but prevents AttributeError. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: xinhe3 <xinhe3@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lv, Liang1 liang1.lv@intel.com
Type of Change
bug fix
API not changed
Description
detail description
JIRA ticket: ILITV-2583
[release2nd][tf2.11.0] centernet_hg104 failed with InvalidArgumentError
Expected Behavior & Potential Risk
OOB centernet_hg104 benchmark issue can be fixed.
How has this PR been tested?
UT, pre-CI and OOB extension test.
Dependency Change?
No.