CVS-165537 Minor fixes to partially enable contrib op tests#1050
Merged
RajeevSekar merged 6 commits intoovep-developfrom Apr 23, 2026
Merged
CVS-165537 Minor fixes to partially enable contrib op tests#1050RajeevSekar merged 6 commits intoovep-developfrom
RajeevSekar merged 6 commits intoovep-developfrom
Conversation
…nxruntime into rajeev/contrib_ops_test
There was a problem hiding this comment.
Pull request overview
This PR updates several contrib-op unit tests to run more broadly with the OpenVINO Execution Provider (where supported), while keeping known-incompatible scenarios excluded to avoid OpenVINO compilation/runtime failures.
Changes:
- Enable
MatMulNBitsfloat32 test coverage with OpenVINO by adding explicit error tolerances and removing theUSE_OPENVINOcompile-time skip. - Update
EmbedLayerNormalizationtests to only exclude OpenVINO when the optional 3rd output (embedding_sum) is requested. - Refine
FusedMatMultest execution provider exclusions so OpenVINO is only excluded foralpha != 1.0andtransBatchcases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
onnxruntime/test/contrib_ops/matmul_4bits_test.cc |
Adds default tolerances for float32 path and removes OpenVINO compile-time gating for float32 accuracy tests. |
onnxruntime/test/contrib_ops/fused_matmul_op_test.cc |
Makes OpenVINO exclusion conditional (scale/transBatch only) while still excluding other unsupported EPs. |
onnxruntime/test/contrib_ops/embed_layer_norm_op_test.cc |
Allows OpenVINO to run when only 2 outputs are used; excludes it when the 3rd output is requested. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/intel/onnxruntime/sessions/537a8eff-dc15-46c4-a79b-cf2b4a21010c Co-authored-by: RajeevSekar <117911837+RajeevSekar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the ticket was for the following 4 contrib ops:
onnxruntime/test/contrib_ops/embed_layer_norm_op_test.cc
onnxruntime/test/contrib_ops/matmul_4bits_test.cc
onnxruntime/test/contrib_ops/dynamic_quantize_matmul_test.cc
onnxruntime/test/contrib_ops/fused_matmul_op_test.cc
Fixes: