Apply llvm/clang patches together #179
Merged
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang and llvm are in a monorepo since llvm 10, so we need to apply them in a single apply_patches call. Otherwise patches in clang folder will not be applied.
fzou1
approved these changes
Sep 24, 2020
woshiyifei
approved these changes
Sep 24, 2020
haonanya
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Improve patching mechanism This backports patches from other branches 1. Check if apply_patches is successful, #175 2. Apply llvm/clang patches together, #179 3. Exit CMake processing when apply_patches failed, #304 Signed-off-by: haonanya <haonan.yang@intel.com> * Skip the rest when apply patch failed Signed-off-by: haonanya <haonan.yang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang and llvm are in a monorepo since llvm 10, so we need to apply them
in a single apply_patches call. Otherwise patches in clang folder will
not be applied.
See #176 (comment)