Improved patching mechanism and printing logs #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenju-he
reviewed
Nov 5, 2020
| # Reads hash-commit from backported patch | ||
| # This function assumes that each of files starts with (for example): | ||
| # From 1a400928bf8fc86fa0f062524c25d0985c94ac6f Mon Sep 17 00:00:00 2001 | ||
| function(get_backport_patch_hash patch_path patch_hash) |
Contributor
There was a problem hiding this comment.
can we use "git rev-parse " to get commit id?
Contributor
Author
There was a problem hiding this comment.
I cannot see how I could read sha1 using git rev-parse from the file containing the patch before patching? Could you share the exact command line which you are thinking?
Contributor
There was a problem hiding this comment.
I probably did a wrong test, rev-parse is not working.
wenju-he
reviewed
Nov 5, 2020
wenju-he
reviewed
Nov 5, 2020
wenju-he
reviewed
Nov 5, 2020
woshiyifei
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.