Update cl_ext_float_atomics patch #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haonanya
force-pushed
the
atomic_half_100
branch
from
9ff5dee to
6c9040c
Compare
This fixes incorrect translation for FP-typed atomic_fetch_sub function and addes tests. Atomic functions which do not support floating types should be translted to FunctionCall such as atomic_inc and atomic_or and so on. When cl_ext_float_atomics is enabled, there are atomic_fetch_sub function declaration on clang headers, but there are no corresponding SPIRV Atomic instructions, so atomic_fetch_sub should be translted to FunctionCall as before. Signed-off-by: haonanya <haonan.yang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes incorrect translation for FP-typed atomic_fetch_sub function
and addes tests.
Atomic functions which do not support floating types should be translted
to FunctionCall such as atomic_inc and atomic_or and so on. When
cl_ext_float_atomics is enabled, there are atomic_fetch_sub function
declaration on clang headers, but there are no corresponding SPIRV Atomic
instructions, so atomic_fetch_sub should be translted to FunctionCall as
before.
Signed-off-by: haonanya haonan.yang@intel.com