Skip to content

Conversation

@wenju-he
Copy link
Contributor

@wenju-he wenju-he commented Feb 9, 2022

Guard atomic_double with cl_khr_int64_base_atomics and
cl_khr_int64_extended_atomics.

Guard atomic_double with cl_khr_int64_base_atomics and
cl_khr_int64_extended_atomics.
@wenju-he wenju-he requested review from cdai2, fzou1 and haonanya February 9, 2022 01:32
@haonanya
Copy link

haonanya commented Feb 9, 2022

Thanks for your fix. This is discussed previously on https://reviews.llvm.org/D106343.
It may need some update on specification level so I submit the patch without cl_khr_int64_base_atomics guard at that time.

@wenju-he wenju-he merged commit bf22153 into intel:ocl-open-90 Feb 9, 2022
@wenju-he
Copy link
Contributor Author

wenju-he commented Feb 9, 2022

Thanks for your fix. This is discussed previously on https://reviews.llvm.org/D106343. It may need some update on specification level so I submit the patch without cl_khr_int64_base_atomics guard at that time.

I see, please follow up, thanks. I think the guard is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants