Skip to content

Conversation

@wenju-he
Copy link
Contributor

No description provided.

@wenju-he wenju-he requested a review from Copilot November 12, 2025 01:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a build failure caused by LLVM commit f63d33da0a51, which removed or relocated the clang/Driver/Options.h header file. The fix removes unused includes of the problematic header along with related llvm/Option headers that are no longer needed.

Key changes:

  • Removed includes for clang/Driver/Options.h, llvm/Option/Arg.h, and llvm/Option/ArgList.h from files where they are not being used
  • Maintains existing LLVM/Clang includes that are still required for the code to function

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
options_compile.cpp Removed three unused includes: clang/Driver/Options.h, llvm/Option/Arg.h, and llvm/Option/ArgList.h
options.cpp Removed two unused includes: llvm/Option/Arg.h and clang/Driver/Options.h

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wenju-he wenju-he requested review from Nuullll, cdai2 and fzou1 November 12, 2025 01:58
Copy link
Contributor

@cdai2 cdai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including these files is not required?

@wenju-he
Copy link
Contributor Author

Including these files is not required?

They are not needed. local build passed.

@wenju-he wenju-he merged commit dfd5996 into intel:main Nov 12, 2025
4 checks passed
@wenju-he wenju-he deleted the clang-Options branch November 12, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants