Add clang patch to enable BFloat16 for SPIR/SPIR-V #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds two Clang patches to enable and enhance BFloat16 support for SPIR/SPIR-V targets. The first patch upgrades __bf16 from a storage-only type to a full arithmetic type with updated mangling and excess precision support. The second patch enables BFloat16 specifically for SPIR/SPIR-V targets by setting the appropriate target configuration.
Key changes:
- Upgrade
__bf16to arithmetic type with new mangling scheme (DF16b) - Remove restrictions on BFloat16 type casting and vector operations
- Enable BFloat16 support for SPIR/SPIR-V targets with proper width, alignment, and format configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| patches/clang/0008-Clang-BFloat16-Upgrade-__bf16-to-arithmetic-type-cha.patch | Implements the core BFloat16 arithmetic type upgrade, removes casting restrictions, and updates type conversion logic |
| patches/clang/0009-Clang-Enable-BFloat16-for-SPIR-SPIR-V.patch | Configures SPIR/SPIR-V target to support BFloat16 with appropriate width, alignment, and format settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| + } | ||
| + | ||
| + /// Determine whether the BFloat type is fully supported on this target, i.e | ||
| + /// arithemtic operations. |
There was a problem hiding this comment.
Corrected spelling of 'arithemtic' to 'arithmetic'.
Suggested change
| + /// arithemtic operations. | |
| + /// arithmetic operations. |
cdai2
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.