-
Notifications
You must be signed in to change notification settings - Fork 86
[CI] Fix ref_llvm and ref_translator in on-push-verification-in-tree task #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix ref_llvm and ref_translator in on-push-verification-in-tree task #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the LLVM and translator references in the on-push-verification-in-tree workflow by dynamically parsing the LLVM version from the branch name instead of hardcoding them to "main". The workflow now extracts the LLVM version from branches following the 'ocl-open-XXX' naming scheme and uses it to construct appropriate release branch references.
Key Changes:
- Added dynamic LLVM version parsing from branch names
- Updated
ref_llvmandref_translatorto use version-specific release branches - Added validation to fail early if branch naming scheme is not followed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| BRANCH="${{ github.base_ref }}" # on: pull_request, otherwise null | ||
| BRANCH=${BRANCH:-${{ github.ref_name }}} # on: push | ||
| LLVM_VERSION_LONG=$(echo $BRANCH | grep -oP 'ocl-open-\K\d+') # Eg. 190 for LLVM 19 |
Copilot
AI
Nov 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment states 'Eg. 190 for LLVM 19' but the grep pattern \K\d+ would match '190' from 'ocl-open-190', not just '19'. The example should clarify this matches the full numeric suffix (e.g., '190' from 'ocl-open-190').
| LLVM_VERSION_LONG=$(echo $BRANCH | grep -oP 'ocl-open-\K\d+') # Eg. 190 for LLVM 19 | |
| LLVM_VERSION_LONG=$(echo $BRANCH | grep -oP 'ocl-open-\K\d+') # Eg. matches '190' from 'ocl-open-190' (full numeric suffix) |
| LLVM_VERSION_LONG=$(echo $BRANCH | grep -oP 'ocl-open-\K\d+') # Eg. 190 for LLVM 19 | ||
| if [ -z "$LLVM_VERSION_LONG" ]; then | ||
| echo "[OPENCL-CLANG] Error: Could not parse LLVM version from branch name '$BRANCH'" | ||
| exit 1 | ||
| fi | ||
| LLVM_VERSION_SHORT=${LLVM_VERSION_LONG::-1} # Eg. 19 for LLVM 19 | ||
| echo "llvm_version=$LLVM_VERSION_SHORT" >> $GITHUB_OUTPUT | ||
Copilot
AI
Nov 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'LLVM_VERSION_LONG' is misleading since it contains '190' (a 3-digit number), while 'LLVM_VERSION_SHORT' contains '19' (a 2-digit number). This logic will fail for LLVM versions 9 and below (e.g., 'ocl-open-90' would produce '9' after removing the last character, but version 100+ would work). Consider renaming to reflect that one contains the padded version and add validation for single-digit versions.
| LLVM_VERSION_LONG=$(echo $BRANCH | grep -oP 'ocl-open-\K\d+') # Eg. 190 for LLVM 19 | |
| if [ -z "$LLVM_VERSION_LONG" ]; then | |
| echo "[OPENCL-CLANG] Error: Could not parse LLVM version from branch name '$BRANCH'" | |
| exit 1 | |
| fi | |
| LLVM_VERSION_SHORT=${LLVM_VERSION_LONG::-1} # Eg. 19 for LLVM 19 | |
| echo "llvm_version=$LLVM_VERSION_SHORT" >> $GITHUB_OUTPUT | |
| # Extract the padded LLVM version (e.g., 190 for LLVM 19, 90 for LLVM 9, 200 for LLVM 20) | |
| LLVM_VERSION_PADDED=$(echo "$BRANCH" | grep -oP 'ocl-open-\K\d+') | |
| if [ -z "$LLVM_VERSION_PADDED" ]; then | |
| echo "[OPENCL-CLANG] Error: Could not parse LLVM version from branch name '$BRANCH'" | |
| exit 1 | |
| fi | |
| # Extract the actual LLVM version (e.g., 19 from 190, 9 from 90, 20 from 200) | |
| if [[ "$LLVM_VERSION_PADDED" =~ ^([0-9]+)0$ ]]; then | |
| LLVM_VERSION_SHORT="${BASH_REMATCH[1]}" | |
| else | |
| echo "[OPENCL-CLANG] Error: Unexpected LLVM version format '$LLVM_VERSION_PADDED' from branch name '$BRANCH'" | |
| exit 1 | |
| fi | |
| echo "llvm_version=$LLVM_VERSION_SHORT" >> $GITHUB_OUTPUT |
update it to provide more detailed info? |
done |
ref_llvm should be 20 for ocl-open-200 branch.