[NFC] Fix warning: Keyword MAIN_DEPENDENCY requires a value, but none was given #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a CMake warning by removing an incorrect MAIN_DEPENDENCY parameter that references an undefined variable. The warning occurred because MAIN_DEPENDENCY was specified without a valid value in the create_pcm function's add_custom_command call.
Key Changes:
- Removed the
MAIN_DEPENDENCY ${MODMAP}line from theadd_custom_commandin thecreate_pcmfunction, asMODMAPis not defined in this function's scope.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdai2
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.