Return error information for variants of SetupError
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Inference` and `Loading` variants of `SetupError` carry more information about the error that was returned, bubble it up so that we provide more information about the error that is being returned. Signed-off-by: Rafael Fernández López <rfernandezl@vmware.com>
Author
|
Converting to draft because of my company internal requirements. If the patch looks fine, when the mentioned internal requirements are lifted I'll mark it ready for review. Sorry for the noise! |
Author
|
Closing, following the rationale in bytecodealliance/wasmtime#7157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InferenceandLoadingvariants ofSetupErrorcarry more information about the error that was returned, bubble it up so that we provide more information about the error that is being returned.