This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Fix insecure prng #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justalittlenoob
force-pushed
the
zpf/fix-insecure-prng
branch
from
675569c to
bc45b7f
Compare
justalittlenoob
force-pushed
the
zpf/fix-insecure-prng
branch
from
bc45b7f to
eb33d6d
Compare
fdiasmor
approved these changes
Aug 5, 2022
skmono
reviewed
Aug 7, 2022
skmono
approved these changes
Aug 7, 2022
skmono
pushed a commit
that referenced
this pull request
Aug 30, 2022
* Fix insecure prng (#3) - Add RDSEED and RDRAND instruction check in compile time - Prioritize RDSEED/RDRAND based RNG to produce random big number * Add RNG support for non-RDRAND, non-RDSEED systems (#5) - Use IPP-Crypto pseudo random number generator if none of those instructions are supported * Removing seed setup and replacing rng function for PrimeGen_BN (#8) - Remove seed setup for prime number generator - Add support to TRNGen_RDSEED and PRNGen_RDRAND for prime number generator Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com>
skmono
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Improve RNG security (#9) * Fix insecure prng (#3) - Add RDSEED and RDRAND instruction check in compile time - Prioritize RDSEED/RDRAND based RNG to produce random big number * Add RNG support for non-RDRAND, non-RDSEED systems (#5) - Use IPP-Crypto pseudo random number generator if none of those instructions are supported * Removing seed setup and replacing rng function for PrimeGen_BN (#8) - Remove seed setup for prime number generator - Add support to TRNGen_RDSEED and PRNGen_RDRAND for prime number generator Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com> * Refactor apply obfuscator (#10) - Refactor apply_obfuscator - minor typo fix * Update version for 1.1.4 * Update ipp-crypto version to use ippcp_2021.6 (#12) - Minor update to use IPP-Crypto v2021.6 * 13 errors building installing questions about docs (#15) * Minor fixes - Fix gbenchmark build error on other platforms - Fixed IPCLTargets typo - Update version to 1.1.4 Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com>
Merged
skmono
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Improve RNG security (#9) * Fix insecure prng (#3) - Add RDSEED and RDRAND instruction check in compile time - Prioritize RDSEED/RDRAND based RNG to produce random big number * Add RNG support for non-RDRAND, non-RDSEED systems (#5) - Use IPP-Crypto pseudo random number generator if none of those instructions are supported * Removing seed setup and replacing rng function for PrimeGen_BN (#8) - Remove seed setup for prime number generator - Add support to TRNGen_RDSEED and PRNGen_RDRAND for prime number generator * Refactor apply obfuscator (#10) - Refactor apply_obfuscator - minor typo fix * Update version for 1.1.4 * Update ipp-crypto version to use ippcp_2021.6 (#12) - Minor update to use IPP-Crypto v2021.6 * 13 errors building installing questions about docs (#15) * Minor fixes - Fix gbenchmark build error on other platforms - Fixed IPCLTargets typo - Update version to 1.1.4 Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com>
skmono
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Cleanup and unittest works - Removed benchmark features from unittests - Added ISO/IEC 18033-6 compliance test in unittest - Added support functions to public/private keys - Rearranged OpenMP tests into cryptography and ops format similar to benchmark - Now has one unittest binary instead of two, OpenMP testing enabled during compile time - Updated flags and build targets accordingly - Updated ci/cd to reflect unittest binary change
skmono
pushed a commit
that referenced
this pull request
Nov 15, 2022
* initial release * Update CODEOWNERS (#1) * Minor updates (#4) * Minor updates - Updated contributors - Added code of conduct - Updated CI/CD * ModExp function: remove padding & code clean (#6) - Remove padding operation in ippsModExp function - Let ippsMBModExp function support modulus of different bit size(in one vector) - Code clean * ippsModExp & unittests: corner case fix (#7) * Improve RNG security (#9) * Fix insecure prng (#3) - Add RDSEED and RDRAND instruction check in compile time - Prioritize RDSEED/RDRAND based RNG to produce random big number * Add RNG support for non-RDRAND, non-RDSEED systems (#5) - Use IPP-Crypto pseudo random number generator if none of those instructions are supported * Removing seed setup and replacing rng function for PrimeGen_BN (#8) - Remove seed setup for prime number generator - Add support to TRNGen_RDSEED and PRNGen_RDRAND for prime number generator Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com> * Refactor apply obfuscator (#10) - Refactor apply_obfuscator - minor typo fix * Update ipp-crypto version to use ippcp_2021.6 (#12) - Minor update to use IPP-Crypto v2021.6 * 13 errors building installing questions about docs (#15) * Minor fixes - Fix gbenchmark build error on other platforms - Fixed IPCLTargets typo - Update version to 1.1.4 * Update to 1.1.4 (#17) (#20) * Improve RNG security (#9) * Fix insecure prng (#3) - Add RDSEED and RDRAND instruction check in compile time - Prioritize RDSEED/RDRAND based RNG to produce random big number * Add RNG support for non-RDRAND, non-RDSEED systems (#5) - Use IPP-Crypto pseudo random number generator if none of those instructions are supported * Removing seed setup and replacing rng function for PrimeGen_BN (#8) - Remove seed setup for prime number generator - Add support to TRNGen_RDSEED and PRNGen_RDRAND for prime number generator * Refactor apply obfuscator (#10) - Refactor apply_obfuscator - minor typo fix * Update version for 1.1.4 * Update ipp-crypto version to use ippcp_2021.6 (#12) - Minor update to use IPP-Crypto v2021.6 * 13 errors building installing questions about docs (#15) * Minor fixes - Fix gbenchmark build error on other platforms - Fixed IPCLTargets typo - Update version to 1.1.4 Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com> * Add ipcl.hpp public header & cleanup ipcl/CMakeLists.txt (#22) * Cleanup ipcl/CMakeLists.txt * Refactor header - rename keygen.hpp with ipcl.hpp, use it as public header * Unit test & benchmark: replace header files with public header - ipcl.hpp * Improve installation and support runtime IFMA detection (#23) * Add option to determine AVX512IFMA during runtime (#18) - Add CMake flag to enable runtime version (```IPCL_DETECT_IFMA_RUNTIME```) - Add ```cpu_features``` dependency - Add manual IFMA disabling with environment variable (```IPCL_DISABLE_AVX512IFMA=ON```) - Updated README to include AVX512IFMA runtime detection option * Fixed shared library build - Refactor cmake configurations - Added example code * Added build and usage documentation - Fixed minor typos and updated flag names to be more consistent - Cleaned up example CMake file * Added examples documentation - Build and install instruction - Linking and compiling instruction - Usage examples * Fixed typo in root README (#24) Co-authored-by: Pengfei Zhao <pengfei.zhao@intel.com>
skmono
pushed a commit
that referenced
this pull request
Nov 16, 2022
Impl of single-threaded synchronous blocking bnModExpPerformOp with batch support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.