-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor thread counts #32
Conversation
|
@justalittlenoob What do you think of this approach? This PR can remove the |
|
Hi @skmono |
… hardcoded fixed value * Set ```IPCL_NUM_NODES``` macro after parsing ```lscpu```
|
@justalittlenoob You're right. Also hard coded |
I have an idea FYI. How about set several options in the compilation options, such as |
…liercryptolib into skmono/refactor_thread_counts
|
@justalittlenoob I added a So there will be following cases:
pailliercryptolib/CMakeLists.txt Line 105 in 745f02d
pailliercryptolib/CMakeLists.txt Lines 120 to 121 in 745f02d
pailliercryptolib/ipcl/include/ipcl/utils/util.hpp Lines 78 to 81 in f121da2
pailliercryptolib/ipcl/utils/util.cpp Lines 11 to 13 in f121da2
What do you think? |
|
There is little difference in performance, as |
justalittlenoob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great.
Remove
numadependency and acquire cores/threads by parsinglscpu