This repository was archived by the owner on Aug 5, 2022. It is now read-only.
xml coverage: fix a copy-paste mistake #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ccb164c introduced the possibility to ignore changes to unknown criterion through an option passed to coverage.py but a copy-paste mistake swapped the action of this option with the option ignoring incoherent criterion state changes. Both flags are set by 'aplog2coverage.sh -f' so the mistake went unnoticed but it must be fixed nevertheless. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
|
👍 |
dawagner
added a commit
that referenced
this pull request
Apr 20, 2015
xml coverage: fix a copy-paste mistake Commit ccb164c introduced the possibility to ignore changes to unknown criterion through an option passed to coverage.py but a copy-paste mistake swapped the action of this option with the option ignoring incoherent criterion state changes. Both flags are set by 'aplog2coverage.sh -f' so the mistake went unnoticed but it must be fixed nevertheless. Signed-off-by: David Wagner david.wagner@intel.com
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ccb164c introduced the possibility to
ignore changes to unknown criterion through an option passed to coverage.py but
a copy-paste mistake swapped the action of this option with the option ignoring
incoherent criterion state changes.
Both flags are set by 'aplog2coverage.sh -f' so the mistake went unnoticed but
it must be fixed nevertheless.
Signed-off-by: David Wagner david.wagner@intel.com