Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@dawagner
Copy link
Contributor

Since a parameter-framework client may set a criterion before calling start(),
the logs may show changes to criteria before the coverage script knows the list
of criteria. It used to cause an unrecoverable error even with the "--force"
option.

This option now makes the coverage script ignore such errors. The script
already takes the initial values of criteria into account when the
parameter-framework starts, so there isn't any information loss.

However, if this error happens for any other error than described in the first
paragraph, you probably don't want to silence it.

Signed-off-by: David Wagner david.wagner@intel.com

Since a parameter-framework client may set a criterion before calling start(),
the logs may show changes to criteria before the coverage script knows the list
of criteria. It used to cause an unrecoverable error even with the "--force"
option.

This option now makes the coverage script ignore such errors. The script
already takes the initial values of criteria into account when the
parameter-framework starts, so there isn't any information loss.

However, if this error happens for any other error than described in the first
paragraph, you probably don't want to silence it.

Signed-off-by: David Wagner <david.wagner@intel.com>
@dawagner
Copy link
Contributor Author

@krocard @gdenneul please review

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.13% when pulling ccb164c on dawagner:xmlcoverage-ignore-unknown-criterion-option into 541735d on 01org:master.

@krocard
Copy link
Contributor

krocard commented Apr 16, 2015

👍

dawagner added a commit that referenced this pull request Apr 16, 2015
…rion-option

xmlcoverage: be able to ignore changes to unknown criteria

Since a parameter-framework client may set a criterion before calling start(),
the logs may show changes to criteria before the coverage script knows the list
of criteria. It used to cause an unrecoverable error even with the "--force"
option.

This option now makes the coverage script ignore such errors. The script
already takes the initial values of criteria into account when the
parameter-framework starts, so there isn't any information loss.

However, if this error happens for any other error than described in the first
paragraph, you probably don't want to silence it.
@dawagner dawagner merged commit ec4f597 into intel:master Apr 16, 2015
@dawagner dawagner deleted the xmlcoverage-ignore-unknown-criterion-option branch April 16, 2015 10:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed by #101

@gdenneul
Copy link
Contributor

👎

@dawagner dawagner added the bug label May 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants