This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Command parser #54
Closed
Command parser #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.travis.yml
Outdated
Contributor
There was a problem hiding this comment.
You will have to rebase on master.
clero
force-pushed
the
command_parser
branch
2 times, most recently
from
9c6ef5f to
a3cf2db
Compare
Contributor
Author
|
updated, this pull request should be rebased on log rework one to be compatible with Android (we need c++11 and clang) |
Contributor
There was a problem hiding this comment.
[this](CommandParser&, const IRemoteCommand&, std::string& result) -> { help(result); }
help will no longer need 2 first useless parameters!
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Some elements are logging but ParameterMgr is able to do the same. This patch lets the ParameterMgr handle logging whenever it's possible. Signed-off-by: Jules Clero <julesx.clero@intel.com>
String lists are often used as containers for function results. To avoid copy paste, this patch introduces the Results type to replace std::list<std::string> when relevant. Documentation has been updated on modified prototype. Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log is meaningless, as we know subsystems we are attempting to load. We log only if there is an error. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log information is easy to retrieve by looking the structure file. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The client may choose if he wants to log the error when adding a criterion. Signed-off-by: Jules Clero <julesx.clero@intel.com>
In prevision of logging rework, this patch removes logging from plugins. Signed-off-by: Jules Clero <julesx.clero@intel.com>
uint8_t type seems to be buggy when we try to log it through stream API. This patch uses uint32_t type instead to count criterion modifications. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Logs were provided by Element god class. This patch moves logging in the log library which is used by the ParameterMgr. Logs remains almost identical from before. Context title after context closing bracket has been removed to enhance readability. Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Plugins are now able to log. An ILogger object is provided to plugins to do that. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
Swig does not any more generates code which require this flag. Moreover this flag is not present in clang compiler. Change-Id: I386ab576e93003d69dcf2c593670245070770024 Signed-off-by: Jules Clero <julesx.clero@intel.com>
accessAsInteger function prototype is defined in BaseParameter abstract class with an uint32_t type. Nevertheless in BitParameter the overloaded function take an uin64_t. It seems that GCC accepts wrongly this mistake but clang don't. This patch corrects the function prototype accordingly to the one defined in BaseParameter. It allows the project to be compiled with clang. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Clang compiler allows to use some great features in the Android PDK (like c++11). Change-Id: Ic80c04b0aff88aa947b3a07c6f35314cc4a7de28 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Swig has been updated in order to avoid the use of Wno-unused-but-set-variable flag which is not present in Clang. The coverage is not supported for now due to gcov compatibility problems with clang. The debug build his also built in a different directory to avoid an empty error of python bindings with clang. Signed-off-by: Jules Clero <julesx.clero@intel.com>
C++11 is now available on Android, thus we can start to use it in the parameter-framework. Signed-off-by: Jules Clero <julesx.clero@intel.com>
ParameterMgr is offered as template parser to the RemoteCommandHandlerTemplate class. This is not his primary job and make the class hard to read. This patch introduces the CommandParser class which handle this job. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
This typedef is already defined in RemoteCommandHandlerTemplate class. As we include its header, we can use it directly. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Remote commands was organised through a vector and browsed many times. This patch introduces the use of a map to use only one command structure and to enhance browsing. Signed-off-by: Jules Clero <julesx.clero@intel.com>
There is no need of using a pointer. Signed-off-by: Jules Clero <julesx.clero@intel.com>
As RemoteCommandHandlerTemplate has been almost completely rewritten, the entire file has been commented and modified to follow new coding style rules. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Some headers in TestPlatorm implementation was present but unused, this patch removes them. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Parsing method of criterion creation was duplicated for inclusive and exclusive criterion. This patch uses template method to avoid that. Signed-off-by: Jules Clero <julesx.clero@intel.com>
RemoteCommandHandler was using old style function pointer to keep commands. This patch introduces the use of function object. The help command is now handled as any other commands thanks to partial function definition. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Contributor
Author
|
close to be reopened on next branch |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍 @krocard @dawagner