Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Log contextualisable subsystems #87

Closed
wants to merge 14 commits into from
Closed

Log contextualisable subsystems #87

wants to merge 14 commits into from

Conversation

@clero
Copy link
Contributor

@clero clero commented Apr 10, 2015

Improvements of #58 , Subsystems are now able to use Context when Logging (and the same API as the ParameterMgr)

@clero
Copy link
Contributor Author

clero commented Apr 10, 2015

C bindings coverage regression need to be fixed

@coveralls
Copy link

coveralls commented Apr 10, 2015

Coverage Status

Coverage decreased (-0.09%) to 69.91% when pulling cde0211 on clero:log_contextualisable_subsystems into 597148e on 01org:master.

clero
clero reviewed Apr 10, 2015
View reviewed changes
parameter/ParameterMgr.h Outdated
Copy link
Contributor Author

@clero clero Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc

Copy link
Contributor Author

@clero clero Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@clero clero mentioned this pull request Apr 13, 2015
Closed
@clero clero force-pushed the log_contextualisable_subsystems branch from cde0211 to 2187d0f Compare April 13, 2015 08:37
@coveralls
Copy link

coveralls commented Apr 13, 2015

Coverage Status

Coverage decreased (-0.09%) to 69.91% when pulling 2187d0f on clero:log_contextualisable_subsystems into 1b071fa on 01org:master.

@clero clero force-pushed the log_contextualisable_subsystems branch 2 times, most recently from 6f673ab to eada476 Compare April 13, 2015 10:04
@coveralls
Copy link

coveralls commented Apr 13, 2015

Coverage Status

Coverage decreased (-0.01%) to 69.99% when pulling eada476 on clero:log_contextualisable_subsystems into 7a848da on 01org:master.

dawagner
dawagner reviewed Apr 13, 2015
View reviewed changes
parameter/ParameterMgr.cpp Outdated
Copy link
Contributor

@dawagner dawagner Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an opportunistic type reuse.

Copy link
Contributor Author

@clero clero Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@clero clero force-pushed the log_contextualisable_subsystems branch from eada476 to 06bdf3b Compare April 13, 2015 14:07
@coveralls
Copy link

coveralls commented Apr 13, 2015

Coverage Status

Coverage increased (+0.01%) to 70.01% when pulling 06bdf3b on clero:log_contextualisable_subsystems into 7a848da on 01org:master.

clero added 2 commits April 14, 2015 09:34
@clero
Remove unused AutoLog header from SelectionCriterion class
5c61b12 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Move logging up to ParameterMgr
6045e01 
Some elements are logging but ParameterMgr is able
to do the same.
This patch lets the ParameterMgr handle logging
whenever it's possible.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero clero force-pushed the log_contextualisable_subsystems branch from 06bdf3b to ec8cf2b Compare April 14, 2015 07:34
@coveralls
Copy link

coveralls commented Apr 14, 2015

Coverage Status

Coverage increased (+0.01%) to 70.14% when pulling ec8cf2b on clero:log_contextualisable_subsystems into 6d605e3 on 01org:master.

clero added 5 commits April 14, 2015 15:25
@clero
Introduce Results type to avoid copy paste
d3d2820 
String lists are often used as containers for function results.
To avoid copy paste, this patch introduces the Results type
to replace std::list<std::string> when relevant.
Documentation has been updated on modified prototype.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove plugin load attempt log
0a524bb 
This log is meaningless, as we know subsystems we are
attempting to load. We log only if there is an error.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove unused XmlFileIncluderElement header from ParameterMgr
b3ba567 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove log from XmlFileIncluderElement
02626eb 
This log information is easy to retrieve by looking
the structure file.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Delegate addValuePair error logging to client
26733e5 
The client may choose if he wants to log the error
when adding a criterion.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
clero added 7 commits April 14, 2015 15:26
@clero
Temporarily remove Subsystems logging ability
b87140c 
In prevision of logging rework, this patch
removes logging from plugins.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Change Criterion modifications counter type
aaefb6c 
uint8_t type seems to be buggy when we try to log it through stream API.
This patch uses uint32_t type instead to count criterion modifications.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Rework project log
67b382d 
Logs were provided by Element god class. This patch
moves logging in the log library which is used by
the ParameterMgr.
Logs remains almost identical from before.
Context title after context closing bracket has been
removed to enhance readability.

Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove unused remote-processor include location from test-subsystem
f0da156 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Enable subsystems logging
9ae0ce3 
Plugins are now able to log.
An ILogger object is provided to plugins to do that.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Update Skeleton Subsystem for log ability.
9f9045c 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Update domainGenerator python script to use the new log API
56657e4 
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero clero force-pushed the log_contextualisable_subsystems branch from ec8cf2b to 56657e4 Compare April 14, 2015 13:30
@coveralls
Copy link

coveralls commented Apr 14, 2015

Coverage Status

Coverage increased (+0.01%) to 70.14% when pulling 56657e4 on clero:log_contextualisable_subsystems into 6d605e3 on 01org:master.

dawagner added a commit that referenced this pull request Apr 14, 2015
@dawagner
Merge pull request #87 from clero/log_contextualisable_subsystems int…
3cfeff4 
…o next
@dawagner
Copy link
Contributor

dawagner commented Apr 14, 2015

rebased onto v2.4.3 and merged in "next".

@dawagner dawagner closed this Apr 14, 2015
@clero clero deleted the log_contextualisable_subsystems branch April 27, 2015 07:35
@krocard krocard mentioned this pull request Aug 25, 2015
Merged
11 tasks
krocard added a commit to krocard/parameter-framework that referenced this pull request Aug 26, 2015
@krocard
Merge pull request intel#87 into windows_port
356dd3b 
Port log rework from next in order to remove dependancies on snprintf
and because it was pending.

Conflicts:
	parameter/Android.mk
	parameter/ConfigurableDomain.cpp
	parameter/ConfigurableDomains.cpp
	parameter/Element.cpp
	parameter/Element.h
	parameter/ParameterMgr.cpp
	parameter/ParameterMgr.h
	parameter/SelectionCriterion.cpp
	parameter/SubsystemObject.cpp
	parameter/SubsystemObject.h
	parameter/SystemClass.cpp
	utility/CMakeLists.txt
krocard added a commit to krocard/parameter-framework that referenced this pull request Aug 26, 2015
@krocard
Merge pull request intel#87 into windows_port
7152e03 
Port log rework from next in order to remove dependancies on snprintf
and because it was pending.

Conflicts:
	parameter/Android.mk
	parameter/ConfigurableDomain.cpp
	parameter/ConfigurableDomains.cpp
	parameter/Element.cpp
	parameter/Element.h
	parameter/ParameterMgr.cpp
	parameter/ParameterMgr.h
	parameter/SelectionCriterion.cpp
	parameter/SubsystemObject.cpp
	parameter/SubsystemObject.h
	parameter/SystemClass.cpp
	utility/CMakeLists.txt
krocard added a commit to krocard/parameter-framework that referenced this pull request Aug 28, 2015
@krocard
Merge pull request intel#87 into windows_port
a1d55e0 
Port log rework from next in order to remove dependancies on snprintf
and because it was pending.

Conflicts:
	parameter/Android.mk
	parameter/ConfigurableDomain.cpp
	parameter/ConfigurableDomains.cpp
	parameter/Element.cpp
	parameter/Element.h
	parameter/ParameterMgr.cpp
	parameter/ParameterMgr.h
	parameter/SelectionCriterion.cpp
	parameter/SubsystemObject.cpp
	parameter/SubsystemObject.h
	parameter/SystemClass.cpp
	utility/CMakeLists.txt
krocard added a commit to krocard/parameter-framework that referenced this pull request Aug 28, 2015
@krocard
Merge pull request intel#87 into windows_port
f5a65cc 
Port log rework from next in order to remove dependancies on snprintf
and because it was pending.

Conflicts:
	parameter/Android.mk
	parameter/ConfigurableDomain.cpp
	parameter/ConfigurableDomains.cpp
	parameter/Element.cpp
	parameter/Element.h
	parameter/ParameterMgr.cpp
	parameter/ParameterMgr.h
	parameter/SelectionCriterion.cpp
	parameter/SubsystemObject.cpp
	parameter/SubsystemObject.h
	parameter/SystemClass.cpp
	utility/CMakeLists.txt
krocard added a commit to krocard/parameter-framework that referenced this pull request Aug 28, 2015
@krocard
Merge pull request intel#87 into windows_port
6be17d8 
Port log rework from next in order to remove dependancies on snprintf
and because it was pending.

Conflicts:
	parameter/Android.mk
	parameter/ConfigurableDomain.cpp
	parameter/ConfigurableDomains.cpp
	parameter/Element.cpp
	parameter/Element.h
	parameter/ParameterMgr.cpp
	parameter/ParameterMgr.h
	parameter/SelectionCriterion.cpp
	parameter/SubsystemObject.cpp
	parameter/SubsystemObject.h
	parameter/SystemClass.cpp
	utility/CMakeLists.txt
krocard added a commit that referenced this pull request Aug 28, 2015
@krocard
Merge pull request #168 from krocard/port_log_from_next
005c390 
Port log rework (#87) from next in order to remove dependencies on `*sprintf` that does not have the same behavior on windows.

Additionally fixed a leak introduced by #87 (port make_unique for that)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clero @coveralls @dawagner